fix: stop logging full git config (credential leak) - #758
Conversation
Avoid dumping listConfig().all via core.debug so checkout extraheader tokens are never written to action logs. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 11 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR prevents accidental credential leakage in GitHub Actions debug logs by removing the debug dump of the full merged git config (which can include http.*.extraheader and token-bearing remote URLs) and replacing it with a narrowly allowlisted “identity-only” snapshot.
Changes:
- Replace full
git.listConfig().alldebug logging with allowlisted identity-only logging gated behind step debug. - Introduce
pickGitIdentityConfig()utility to select only safe identity keys (user/author/committername/email). - Add unit tests ensuring credential-bearing keys are never included; rebuild the bundled
lib/output.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/main.ts |
Stops dumping full git config; logs only allowlisted identity keys when debug is enabled. |
src/util.ts |
Adds pickGitIdentityConfig() and the allowlisted identity key set used for safe logging. |
test/util.test.ts |
Adds unit tests validating only identity keys are retained and credential keys are excluded. |
lib/index.js |
Updates compiled/bundled output to reflect the new safe debug logging behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
git.listConfig().allto stdout viacore.debug(), which could includeactions/checkout's base64GITHUB_TOKENinhttp.*.extraheader.user/author/committername and email).lib/.Test plan
npm test(unit tests + lint)npm run buildextraheader/AUTHORIZATION basicin stdout withoutRUNNER_DEBUGACTIONS_STEP_DEBUG=true, confirm only identity keys appear in the debug logMade with Cursor